Skip to content

Simplify and modularize aggregate verifier + verifiers#201

Merged
roger-bai-coinbase merged 139 commits intomainfrom
simplify-and-modularize-aggregate-verifier
Mar 11, 2026
Merged

Simplify and modularize aggregate verifier + verifiers#201
roger-bai-coinbase merged 139 commits intomainfrom
simplify-and-modularize-aggregate-verifier

Conversation

@roger-bai-coinbase
Copy link
Contributor

@roger-bai-coinbase roger-bai-coinbase commented Mar 5, 2026

  • TEE proof can be challenged with a ZK proof using intermediary roots
  • Game can still progress after a TEE nullification or ZK nullification by providing a proof of the un-nulllified system
  • Game can not progress if both proof systems nullified
  • Bond for games that cannot progress are unlocked after 2 weeks from initialization time
  • Nullifying strictly increases resolution time to allow time to intervene
  • Challenges strictly increase resolution time to allow time to nullify the challenge
  • Nullification automatically disables the nullified proof system, preventing further proof verifications from any game

…andling into a single function, improving code clarity and maintainability. Update tests accordingly to reflect the new verification structure.
…ild game in AggregateVerifier. Implement corresponding test case to verify this behavior.
…d rollup configuration. Update verification methods to use a journal hash instead of root claims. Modify MockVerifier and tests accordingly.
…ier, updating documentation and logic to clarify its purpose as the L2 sequence number.
…rnal to public, enhancing accessibility for contract interactions.
…er for consistency with internal function naming conventions.
…nsolidating the return statement for the first dispute game scenario.
@leopoldjoy
Copy link
Contributor

@roger-bai-coinbase Nit: would it be possible to add a description to the PR? I started reviewing it but ran into some difficulty understanding the objectives (particularly in light of all of the different considerations we've been discussing of late).

@roger-bai-coinbase
Copy link
Contributor Author

@roger-bai-coinbase Nit: would it be possible to add a description to the PR? I started reviewing it but ran into some difficulty understanding the objectives (particularly in light of all of the different considerations we've been discussing of late).

Done

Base automatically changed from joby.thundil/CHAIN-3293-migrate-multiproof-contracts-to-basecontracts to main March 6, 2026 18:06
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 6, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@roger-bai-coinbase roger-bai-coinbase merged commit 0e6419b into main Mar 11, 2026
8 checks passed
@roger-bai-coinbase roger-bai-coinbase deleted the simplify-and-modularize-aggregate-verifier branch March 11, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants